fix: connections activation autumn

[MaheshtheDev]

No description provided.

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Updated (UTC)
✅ Deployment successful! View logs	supermemory-app	7b632e1	Sep 12 2025, 12:57 AM

[MaheshtheDev]

• fix: connections activation autumn #419 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add the label Main to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

PR Review: Fix Connections Activation Autumn

🎯 Summary

This PR refactors the connections activation logic by removing dependency on fetchConsumerProProduct and implementing direct customer state management through the autumn-js SDK.

🚀 Positive Changes

• Simplified Pro Status Check: Direct access to customer products is more efficient than separate API call
• Consistent Semicolon Usage: Proper adoption of repository's semicolon-free style guide
• Better State Management: Using React state for isProUser provides better control over timing
• Loading State Handling: Added proper check for autumn.isLoading before showing upgrade prompt

⚠️ Issues & Recommendations

1. Type Safety Concerns

• Line 122: fetchConnectionsFeature(autumn) - The autumn parameter is typed as any in the original query function
• Line 134: Casting autumn as any was removed but the underlying type issue remains
• Recommendation: Update fetchConnectionsFeature to accept proper Autumn customer type

2. Potential Race Condition

• Lines 107-115: The useEffect for setting isProUser could cause unnecessary re-renders
• Issue: State updates may occur after component unmount in edge cases
• Recommendation: Add cleanup or use useMemo instead:

const isProUser = useMemo(() => {
  if (autumn.isLoading) return false
  return autumn.customer?.products.some(
    (product) => product.id === "consumer_pro"
  ) ?? false
}, [autumn.isLoading, autumn.customer])

3. Logic Inconsistency

• Line 525: Button is disabled when !isProUser but also checks addConnectionMutation.isPending
• Line 170: The mutation itself already handles the pro user check
• Issue: Double validation could lead to confusing UX
• Recommendation: Either handle it in UI OR mutation, not both

4. Missing Error Handling

• Lines 107-115: No error handling for autumn customer state
• Recommendation: Add error boundary or fallback state

5. Performance Consideration

• Line 110: The .some() operation runs on every render when autumn.customer changes
• Impact: Minor performance hit with large product arrays
• Recommendation: Consider memoization if product arrays become large

🔒 Security Assessment

• ✅ No security vulnerabilities introduced
• ✅ Proper error message handling maintained
• ✅ No sensitive data exposure

🧪 Testing Considerations

• Missing: Tests for the new isProUser state logic
• Recommendation: Add unit tests for:
  • Loading state handling
  • Pro user detection logic
  • Edge cases when autumn.customer is undefined

📊 Code Quality Score: 7.5/10

Strengths:

• Clean refactoring removing unnecessary API dependency
• Consistent code style
• Better loading state management

Areas for Improvement:

• Type safety
• Race condition prevention
• Logic consolidation

🛠️ Suggested Next Steps

1. Fix type safety issues with autumn customer type
2. Replace useState + useEffect with useMemo for isProUser
3. Consolidate pro user validation logic (either UI or API, not both)
4. Add unit tests for the new logic
5. Consider error handling for autumn customer state

Overall: Good refactoring direction but needs some polish for production readiness.

[graphite-app]

Merge activity

• Sep 12, 12:50 AM UTC: CodeWithShreyans added this pull request to the Graphite merge queue.
• Sep 12, 12:52 AM UTC: Merged by the Graphite merge queue.

[graphite-app]

[claude]

Code Review: Connections Activation Autumn

Thank you for this PR! I've reviewed the changes and have some feedback:

✅ Positive Changes

1. Style Consistency: Removing semicolons aligns with the Biome configuration and improves code consistency across the codebase.

2. Improved Pro User Detection Logic: The new useEffect approach for determining pro user status is more robust and handles loading states properly.

3. Enhanced UX: The conditional rendering {\!autumn.isLoading && \!isProUser && (...)} prevents the upgrade prompt from flashing during loading.

⚠️ Issues & Concerns

Critical Issue - Removed Import

apps/web/components/views/integrations.tsx:13

- import { fetchConsumerProProduct } from "@repo/lib/queries"

The fetchConsumerProProduct import was removed but I need to verify this isn't breaking functionality elsewhere. This could be intentional if the logic was properly replaced, but it's a significant change.

Logic Changes

The pro user detection logic changed from:

const { data: proCheck } = fetchConsumerProProduct(autumn as any)
const isProUser = proCheck?.allowed ?? false

To:

const [isProUser, setIsProUser] = useState(false)
useEffect(() => {
  if (\!autumn.isLoading) {
    setIsProUser(
      autumn.customer?.products.some(
        (product) => product.id === "consumer_pro"
      ) ?? false
    )
  }
}, [autumn.isLoading, autumn.customer])

Questions:

• Is fetchConsumerProProduct no longer needed anywhere?
• Does the new logic correctly identify all pro user states?
• Should we handle the case where autumn.customer is null/undefined more explicitly?

Minor Issues

1. Button Disability Logic:

   disabled={addConnectionMutation.isPending || \!isProUser}

   This disables the button for non-pro users even when they have available connections within their limit. Should consider the canAddConnection logic here.

2. Loading State Handling: The upgrade prompt now only shows for loaded non-pro users, but we might want to consider showing a skeleton/loading state.

🧪 Testing Recommendations

1. Test pro user detection with different customer states
2. Verify connection creation works for both free and pro users
3. Test the upgrade flow functionality
4. Ensure no regressions in authentication flows

📋 Minor Style Suggestions

1. Consider adding a comment explaining the pro user detection logic
2. The SVG attribute reordering is fine but ensure it doesn't affect accessibility

🔍 Questions for Author

1. What specific issue was this PR addressing? ("autumn" in the title suggests seasonal/time-related?)
2. Has the removal of fetchConsumerProProduct been tested across all user types?
3. Are there any breaking changes we should be aware of?

Overall, this looks like a solid improvement to the user experience and code consistency, but please address the import removal and confirm the logic changes are intentional and tested.