Skip to content

fix: set an implicit root in external build if parents are not set#147

Merged
usamoi merged 1 commit into
supervc-stack:mainfrom
usamoi:fallback
Dec 23, 2024
Merged

fix: set an implicit root in external build if parents are not set#147
usamoi merged 1 commit into
supervc-stack:mainfrom
usamoi:fallback

Conversation

@usamoi

@usamoi usamoi commented Dec 23, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@VoVAllen

VoVAllen commented Dec 23, 2024

Copy link
Copy Markdown
Contributor

Add some e2e tests, use ai to generate it if needed

@cutecutecat

Copy link
Copy Markdown
Contributor

Thanks, or maybe you can merge it straightly, and I would write the tests together with the type check PR.

@usamoi
usamoi requested a review from cutecutecat December 23, 2024 09:11

@cutecutecat cutecutecat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usamoi
usamoi merged commit 6335852 into supervc-stack:main Dec 23, 2024
usamoi added a commit that referenced this pull request Jan 8, 2025
pick #106, #147 and #149 to vchordrqfscan

Signed-off-by: usamoi <usamoi@outlook.com>
spenc-r pushed a commit to spenc-r/VectorChord that referenced this pull request May 22, 2026
spenc-r pushed a commit to spenc-r/VectorChord that referenced this pull request May 22, 2026
pick supervc-stack#106, supervc-stack#147 and supervc-stack#149 to vchordrqfscan

Signed-off-by: usamoi <usamoi@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants