build: fix target features for rustc 1.96#467
Closed
CertainLach wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Yaroslav Bolyukin <iam@lach.pw>
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
It seems that it was not caused by rustc this time, but incorrect rustc packaging in nixos This patch can be merged for correctness WRT implied features ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, build of vchord fails on rustc 1.96 with
rustc-LLVM ERROR: Cannot select: intrinsic %llvm.x86.avx512.vpdpbusd.512This intrinsic is a part of
avx512f, which doesn't seem to be enabled here. The way it worked previously is I guess because it was most likely implied by otheravx512featuresI haven't found the exact rustc bug, but it seems this kind of problems is not something new, and better avoided by specifying features explicitly
cfg(target_feature)rust-lang/rust#134792#[target_feature(enable = "simd128")]does not work properly on 1.73, but work fine on 1.72.1 rust-lang/rust#116516