-
Notifications
You must be signed in to change notification settings - Fork 40
feat: Added metal3 BMH selection tip #885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
500dbb5 to
5b26511
Compare
|
I'll wait for a formal review from @ranjinimn before merging it. Thanks @hardys |
|
@ranjinimn any review comments or should we go ahead and merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question and a suggestion.
I just reviewed and had a small comment. |
Also included the metal3 tips and tricks section that was missing
5b26511 to
0c840bf
Compare
Thanks @ranjinimn I pushed your suggestion. Would you mind to take a look again just in case? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Also included the metal3 tips and tricks section that was missing (cherry picked from commit aed5834)
Also included the metal3 tips and tricks section that was missing (cherry picked from commit aed5834)
Also included the metal3 tips and tricks section that was missing (cherry picked from commit aed5834)
Also included the metal3 tips and tricks section that was missing (cherry picked from commit aed5834)
Also included the metal3 tips and tricks section that was missing (cherry picked from commit aed5834)
Also included the metal3 tips and tricks section that was missing (cherry picked from commit aed5834)
Also included the metal3 tips and tricks section that was missing
Closes #876