Skip to content

Conversation

@e-minguez
Copy link
Collaborator

Also included the metal3 tips and tricks section that was missing

Closes #876

@e-minguez e-minguez force-pushed the metal3-tips branch 2 times, most recently from 500dbb5 to 5b26511 Compare October 9, 2025 13:34
@e-minguez e-minguez requested a review from hardys October 9, 2025 13:36
hardys
hardys previously approved these changes Oct 9, 2025
@e-minguez
Copy link
Collaborator Author

I'll wait for a formal review from @ranjinimn before merging it. Thanks @hardys

@hardys
Copy link
Contributor

hardys commented Oct 14, 2025

@ranjinimn any review comments or should we go ahead and merge this?

Copy link
Collaborator

@ranjinimn ranjinimn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question and a suggestion.

@ranjinimn
Copy link
Collaborator

@ranjinimn any review comments or should we go ahead and merge this?

I just reviewed and had a small comment.

Also included the metal3 tips and tricks section that was missing
@e-minguez
Copy link
Collaborator Author

@ranjinimn any review comments or should we go ahead and merge this?

I just reviewed and had a small comment.

Thanks @ranjinimn I pushed your suggestion. Would you mind to take a look again just in case? Thanks.

@e-minguez e-minguez requested a review from ranjinimn October 14, 2025 11:54
Copy link
Collaborator

@ranjinimn ranjinimn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@e-minguez e-minguez merged commit aed5834 into suse-edge:main Oct 14, 2025
1 check passed
@e-minguez e-minguez deleted the metal3-tips branch October 14, 2025 15:30
e-minguez added a commit to e-minguez/suse-edge-docs that referenced this pull request Oct 14, 2025
Also included the metal3 tips and tricks section that was missing

(cherry picked from commit aed5834)
e-minguez added a commit to e-minguez/suse-edge-docs that referenced this pull request Oct 14, 2025
Also included the metal3 tips and tricks section that was missing

(cherry picked from commit aed5834)
e-minguez added a commit to e-minguez/suse-edge-docs that referenced this pull request Oct 14, 2025
Also included the metal3 tips and tricks section that was missing

(cherry picked from commit aed5834)
e-minguez added a commit to e-minguez/suse-edge-docs that referenced this pull request Oct 15, 2025
Also included the metal3 tips and tricks section that was missing

(cherry picked from commit aed5834)
e-minguez added a commit to e-minguez/suse-edge-docs that referenced this pull request Oct 15, 2025
Also included the metal3 tips and tricks section that was missing

(cherry picked from commit aed5834)
e-minguez added a commit that referenced this pull request Oct 15, 2025
Also included the metal3 tips and tricks section that was missing

(cherry picked from commit aed5834)
e-minguez added a commit that referenced this pull request Oct 15, 2025
Also included the metal3 tips and tricks section that was missing

(cherry picked from commit aed5834)
e-minguez added a commit that referenced this pull request Oct 15, 2025
Also included the metal3 tips and tricks section that was missing

(cherry picked from commit aed5834)
ranjinimn pushed a commit to ranjinimn/suse-edge.github.io that referenced this pull request Oct 21, 2025
Also included the metal3 tips and tricks section that was missing

(cherry picked from commit aed5834)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[rfe] Add some metal3 best practices

3 participants