Fix two crash/runaway-loop bugs - #1
Merged
Merged
Conversation
* variables-store: avoid infinite recursion (stack overflow) in set_member_value when both raw_value and definition.default_value fail to parse as a number. A plugin declaring a NUMBER xbar.var with a non-numeric default (e.g. number(THRESHOLD=auto)) would crash Sidewing on first sync. Now we try the default once, then fall back to 0. * plugin-manager: drop async plugin-refresh results for records that are no longer tracked (e.g. after reload removed them from plugin_records). Previously the stale Idle callback would push old state into the bar and could re-spawn an orphan refresh thread via refresh_queued.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set_member_value when both raw_value and definition.default_value
fail to parse as a number. A plugin declaring a NUMBER xbar.var with
a non-numeric default (e.g. number(THRESHOLD=auto)) would crash
Sidewing on first sync. Now we try the default once, then fall back
to 0.
are no longer tracked (e.g. after reload removed them from
plugin_records). Previously the stale Idle callback would push old
state into the bar and could re-spawn an orphan refresh thread via
refresh_queued.