fix: format all created project files so fresh projects pass lint#1192
Merged
Conversation
When prettier is among the scaffolded add-ons, format the whole project rather than only the add-on-touched files, so a fresh project passes its own lint. Prettier's ignore rules still apply. Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
|
Install the latest version of pnpm add https://pkg.svelte.dev/sv/c/4e89aa185ae0f34b7f2a419590313ee3f44a1fe0Open in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: 4e89aa1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jycouet
approved these changes
Jul 25, 2026
jycouet
left a comment
jycouet
left a comment
Contributor
There was a problem hiding this comment.
Thank you, I'll merge this.
I will close the other one! (I did something wrong, sorry!)
And I will bring main to version-1
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #1134 / #1170 to
main, as @jycouet asked.When a project is scaffolded with prettier among the add-ons,
sv createnow formats the whole project (['.']) rather than only the add-on-touched file list, so a freshly created project passes its ownpnpm lint. Prettier's own ignore rules apply, so generated and ignored files are left alone.The version-1 branch and
mainhad diverged inpackages/sv/src/cli/create.ts, andmainadditionally haspackages/sv/src/core/formatFiles.ts, so this is a port rather than a cherry-pick.Test:
packages/sv/src/create/tests/check.tsscaffolds a demo project with prettier + eslint, plants astatic/ignored.jsonartifact, and asserts formatting leaves it untouched.vitest run packages/sv/src/create/tests/check.ts-> 29 passed locally.One thing worth a look: the test needs
createProjectexported fromcli/create.ts. Happy to restructure if you'd rather not widen that surface.