Skip to content

breaking: replace 'off' with false for data-sveltekit-* link options#15907

Open
teemingc wants to merge 4 commits into
version-3from
remove-off-option
Open

breaking: replace 'off' with false for data-sveltekit-* link options#15907
teemingc wants to merge 4 commits into
version-3from
remove-off-option

Conversation

@teemingc
Copy link
Copy Markdown
Member

@teemingc teemingc commented May 24, 2026

closes #13597

This PR removes the 'off' option in favour of false. See #10555 (comment) for more information


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 24, 2026

🦋 Changeset detected

Latest commit: 7d5b064

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Contributor

@vercel vercel Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Suggestion:

Test files use data-sveltekit-*="off" which is no longer a valid option after the breaking change that removed 'off' from the valid link options.

Fix on Vercel

@teemingc teemingc linked an issue May 25, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Discrepancy between documentation and typings

1 participant