Skip to content

breaking: make getRequest and setResponse synchronous#16280

Merged
Rich-Harris merged 2 commits into
version-3from
sync-node-helpers
Jul 8, 2026
Merged

breaking: make getRequest and setResponse synchronous#16280
Rich-Harris merged 2 commits into
version-3from
sync-node-helpers

Conversation

@Rich-Harris

Copy link
Copy Markdown
Member

Not sure why these were ever async. They don't need to be. The danger of course is that one day they might need to be, but I'm not sure why that would be the case.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@pkg-svelte-dev

pkg-svelte-dev Bot commented Jul 8, 2026

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from 1f6724a:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/1f6724af850566c96abbc0b059221768887f0af2

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16280

@svelte-docs-bot

Copy link
Copy Markdown

@Rich-Harris Rich-Harris merged commit 07c207e into version-3 Jul 8, 2026
18 checks passed
@Rich-Harris Rich-Harris deleted the sync-node-helpers branch July 8, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants