Skip to content

fix: skip unnecessary version.json checks if updated.current is already true#16518

Open
Rich-Harris wants to merge 5 commits into
version-3from
skip-unnecessary-update-checks
Open

fix: skip unnecessary version.json checks if updated.current is already true#16518
Rich-Harris wants to merge 5 commits into
version-3from
skip-unnecessary-update-checks

Conversation

@Rich-Harris

Copy link
Copy Markdown
Member

If we already know that there's a new deployment, updated.check() should be a no-op. Otherwise we'll request version.json when navigation fails even if we already know the answer


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@pkg-svelte-dev

pkg-svelte-dev Bot commented Jul 25, 2026

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from 13b2fdd:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/13b2fddeb29e04cc22ab3734b007694c75a7c5a2

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16518

@changeset-bot

changeset-bot Bot commented Jul 25, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 13b2fdd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant