fix: serve static files with the Content-Type recorded in the manifest - #16564
Merged
Rich-Harris merged 2 commits intoJul 30, 2026
Merged
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/31f8060356a464827a50377fc5df2fd9a980728bOpen in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: 31f8060 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Jul 29, 2026
Rich-Harris
approved these changes
Jul 30, 2026
Rich-Harris
added a commit
that referenced
this pull request
Jul 30, 2026
…ecompressed (#16566) The remaining half of #10343, and the first concrete piece of #16565. #15182 stopped the header when `precompress` is `false`. It still goes out on every asset when `precompress` is `true`, because `sirv` sets `Vary` from its options rather than from the file, while `builder.compress` only compresses a fixed extension list. So a `.ico` or a `.png` advertises a variant that was never produced. Only extensions that were written but never compressed lose the header, since `setHeaders` sees the request pathname, not the file `sirv` resolved, and `/` or `/v1.0` may be serving `index.html.gz`. Commits are separated by layer so the kit-side and adapter-side changes can be reviewed apart. This rewrites the same `setHeaders` block as #16564, so whichever lands first, the other needs a rebase. --------- Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up the
adapter-nodehalf of #13753.#16234 fixed
.icoby addingmimes['ico']to the sharedmrmimemodule. That works in dev and preview, which share one instance withsirv.adapter-nodebundles its own copy ofmrmimethroughsirv, so the patch never reaches it and.icostill goes out with an emptyContent-Typein production.The manifest already records the right type at build time, resolved through the patched lookup, so this reads it back rather than relying on
sirv's copy.