chore: remove dependency on chokidar - #16621
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/6ae7a0a8e75fe76ecd256638b15229cc7d7bcc9cOpen in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: 6ae7a0a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Seems like |
|
Opened sveltejs/language-tools#3092 to track that |
|
huh, tests are failing locally in |
|
Reverting: #16641 |
Reverts #16621 — doing this rather than fixing it because it's not a Kit 3 priority. This broke stuff silently (because `watch` tests don't run in CI). The issue is that renames aren't properly accounted for — renaming a directory `foo` to `bar` (or `sub` to `sub2` in the test) means that pending `unlink` events are created for everything inside `foo`, with no corresponding events for the files that are now inside `bar`. As a result, files are removed from the output directory instead of being renamed (or recreated).
3 participants
Same treatment #15272 gave sade, applied to chokidar: watch mode needs recursive file events with unlink detection, and
fs.watch(dir, { recursive: true })provides them at the Node 22 floor.