fix: explain removed $lib and $service-worker imports - #16635
Open
Nic-Polumeyv wants to merge 1 commit into
Open
fix: explain removed $lib and $service-worker imports#16635Nic-Polumeyv wants to merge 1 commit into
$lib and $service-worker imports#16635Nic-Polumeyv wants to merge 1 commit into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/2f2f0a10fc9d7ee0eaef853993c1e2a623ed9374Open in |
🦋 Changeset detectedLatest commit: 2f2f0a1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| const resolved = await this.resolve(id, importer, { ...options, skipSelf: true }); | ||
| if (resolved) return resolved; | ||
|
|
||
| for (const { pattern, message } of removed_modules) { |
Contributor
There was a problem hiding this comment.
The resolveId handler throws the misleading "$lib has been removed" migration error for any unresolved $lib/... import even when the user has re-added a $lib alias (the workaround the message itself recommends), masking genuine missing-file/typo errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #16628