fix: identify circular imports from src/env - #17014
Merged
elliott-with-the-longest-name-on-github merged 3 commits intoSep 4, 2026
Merged
fix: identify circular imports from src/env#17014elliott-with-the-longest-name-on-github merged 3 commits into
elliott-with-the-longest-name-on-github merged 3 commits into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/2c90fd575e104fd3c4be91756495774e8585d906Open in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: 2c90fd5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dummdidumm
marked this pull request as ready for review
September 3, 2026 13:12
ottomated
reviewed
Sep 3, 2026
Contributor
|
@svelte-triage-bot Throw the error using |
Contributor
Author
|
Implemented and pushed the
I also recorded this feedback in svelte-agent#5. |
elliott-with-the-longest-name-on-github
approved these changes
Sep 4, 2026
elliott-with-the-longest-name-on-github
merged commit Sep 4, 2026
ee2f55b
into
sveltejs:version-3
36 of 37 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17013.
When
src/envimports a dependency that imports$app/env/privateor$app/env/public, loading the environment configuration depends on modules that have not yet been generated.Recognize this resolution failure and report the circular dependency directly instead of exposing the internal generated-module path. When available, the diagnostic now identifies the project-relative module that imported
$app/env/privateor$app/env/public.A regression test covers the transitive helper-import pattern and verifies that the responsible helper module is reported.
Testing
pnpm vitest run -c vitest.kit.config.js src/core/sync/sync.spec.js --reporter=verbosepnpm -F @sveltejs/kit test:unitpnpm formatpnpm -F @sveltejs/kit lintpnpm -F @sveltejs/kit prepublishOnly