Skip to content

chore: use a UUID instead of Netlify's function token - #17044

Merged
teemingc merged 3 commits into
version-3from
netlify-split-uuid
Sep 7, 2026
Merged

chore: use a UUID instead of Netlify's function token#17044
teemingc merged 3 commits into
version-3from
netlify-split-uuid

Conversation

@teemingc

@teemingc teemingc commented Sep 7, 2026

Copy link
Copy Markdown
Member

Follow-up on #17022 (comment)

This PR opts to generating a unique ID that Netlify split serverless functions check before restoring the requested original URL pathname. This approach works with Netlify edge functions too that don't have the process.env.NETLIFY_FUNCTIONS_TOKEN environment variable.

@pkg-svelte-dev

pkg-svelte-dev Bot commented Sep 7, 2026

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from 00f3037:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/00f30372342b6fff46a1d2b7470d7d4914587e86

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/17044

@changeset-bot

changeset-bot Bot commented Sep 7, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 00f3037

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-netlify Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@teemingc teemingc changed the title chore: use a UUID instead of Netlify's token chore: use a UUID instead of Netlify's function token Sep 7, 2026
@teemingc teemingc added pkg:adapter-netlify needs-platform-tests This PR needs to run platform tests in order to merge. labels Sep 7, 2026
@svelte-docs-bot

Copy link
Copy Markdown

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: QUIET

Plan: Advanced

Run ID: 4483d49c-e20d-4586-8bb8-a74b84280e36

📥 Commits

Reviewing files that changed from the base of the PR and between 056d48f and 00f3037.

📒 Files selected for processing (1)
  • .changeset/wicked-masks-end.md
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • sveltejs/vite-plugin-svelte (manual)
  • vitejs/vite (manual)
  • sveltejs/svelte (manual)

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

Netlify serverless-function generation now uses positional parameters and creates a per-build UUID for split deployments. Generated split and catch-all modules receive the UUID. Catch-all modules record the incoming request pathname in a UUID-derived header. Split modules restore the pathname from that header before responding. The previous token-based full-URL reconstruction path has been removed.

Merge Risk: ⚪ Minimal · up to 00f30

This release note documents UUID-based pathname restoration for Netlify split functions, including environments without the Netlify function token. No current merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Backward Compatibility Impact Disclosure ✅ Passed The pull request does not introduce a breaking public interface change. The public AdapterOptions declaration remains unchanged, with optional edge and split options and the same defaults. The p…
Title check ✅ Passed The title uses the required chore: prefix and accurately summarises the main change: replacing Netlify’s function token with a UUID.

Comment @coderabbitai help to get the list of available commands.

@teemingc
teemingc merged commit a7a78ba into version-3 Sep 7, 2026
41 checks passed
@teemingc
teemingc deleted the netlify-split-uuid branch September 7, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-platform-tests This PR needs to run platform tests in order to merge. pkg:adapter-netlify

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants