Fix load_config on Windows - #399
Merged
Merged
Conversation
GrygrFlzr
commented
Feb 21, 2021
GrygrFlzr
commented
Member
- Fixes load_config fails in windows #396 (load_config fails on Windows)
- Added test to check that loading a blank config file works
dummdidumm
approved these changes
Feb 21, 2021
benmccann
reviewed
Feb 21, 2021
| @@ -0,0 +1,38 @@ | |||
| // import { mkdtempSync, writeFileSync, readdirSync, mkdirSync } from 'fs'; | |||
Member
There was a problem hiding this comment.
can we remove the commented out lines?
Member
Author
There was a problem hiding this comment.
Whoops, copy pasted that from the existing adapt test:
kit/packages/kit/src/api/adapt/test/index.mjs
Lines 1 to 2 in 22063f8
I'll remove the one in adapt in #398 instead, since it modifies that file anyway.
benmccann
approved these changes
Feb 21, 2021
| const __filename = fileURLToPath(import.meta.url); | ||
| const __dirname = join(__filename, '..'); | ||
|
|
||
| const suite = uvu.suite('Builder'); |
Member
There was a problem hiding this comment.
my only question would be whether this is the best way to set things up. Perhaps @Rich-Harris or @lukeed would know best
Member
|
thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.