Skip to content

Conversation

@Rich-Harris
Copy link
Member

closes #7876. This is an alternative to #7879 — the issue is that the click handler doesn't run until after Svelte has updated the DOM, meaning in some cases the element no longer exists in the DOM. In those cases it probably makes sense to bail altogether.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Nov 29, 2022

🦋 Changeset detected

Latest commit: a6f90bd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member Author

We should probably merge #7828 first, since it touches a lot of this stuff

// SVG <a> elements have a lowercase name
a = /** @type {HTMLAnchorElement | SVGAElement} */ (element);
}
if (document.contains(element)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style suggestion: do a if (..) return here instead, to safe some indentation (also I don't need to keep that if statement in my head as much)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

find_anchor: null - (reading 'nodeType')

3 participants