Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/light-papayas-agree.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

Ignore elements that are no longer in the document
2 changes: 1 addition & 1 deletion packages/kit/src/runtime/client/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ function parent_element(element) {
* @param {Element} target
*/
export function find_anchor(element, target) {
while (element !== target) {
while (element && element !== target) {
if (element.nodeName.toUpperCase() === 'A') {
return /** @type {HTMLAnchorElement | SVGAElement} */ (element);
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<script>
let visible = true;

function toggle() {
visible = !visible;
}
</script>

{#if visible}
<button on:click={toggle}>remove</button>
{:else}
<button on:click={toggle}>add</button>
{/if}
19 changes: 19 additions & 0 deletions packages/kit/test/apps/basics/test/client.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -1184,3 +1184,22 @@ test.describe('cookies', () => {
await expect(page.locator('p')).toHaveText('foo=bar');
});
});

test.describe('Interactivity', () => {
test('click events on removed elements are ignored', async ({ page }) => {
let errored = false;

page.on('pageerror', (err) => {
console.error(err);
errored = true;
});

await page.goto('/interactivity/toggle-element');
expect(await page.textContent('button')).toBe('remove');

await page.click('button');
expect(await page.textContent('button')).toBe('add');

expect(errored).toBe(false);
});
});