Skip to content

Conversation

@manuel3108
Copy link
Member

ecosystem-ci is red today. This appears to be related to #16188. This copies down the types from esrap which makes the error go away.

@changeset-bot
Copy link

changeset-bot bot commented Nov 26, 2025

⚠️ No Changeset found

Latest commit: 5942a38

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@17255

@jasonlyu123
Copy link
Member

If the import is in a .d.ts file. Adding an import 'esrap' before import ts from 'esrap/languages/ts' seems safe. It was transformed into a /// <reference types="esrap" /> when running pnpm generate:types.

The copying solution also fixes another problem with @typescript-eslint/types import under skipLibCheck: false. If we didn't copy the types, we might still need to make @typescript-eslint/types a dependency of esrap. It's relatively lean, so it might be fine? Or we might need something like sveltejs/kit#14949

@svelte-docs-bot
Copy link

@manuel3108
Copy link
Member Author

ecosystem-ci is green again, without anyone changing anything. No clue why. Therefore, this is no longer needed.

@manuel3108 manuel3108 closed this Nov 29, 2025
@manuel3108 manuel3108 deleted the fix/print-types branch November 29, 2025 19:27
@manuel3108 manuel3108 restored the fix/print-types branch November 30, 2025 08:24
@manuel3108 manuel3108 reopened this Nov 30, 2025
@manuel3108 manuel3108 marked this pull request as ready for review December 1, 2025 19:38
@manuel3108 manuel3108 marked this pull request as draft December 1, 2025 19:38
@manuel3108
Copy link
Member Author

Undraft after merging sveltejs/esrap#96 and updating esrap here.

@benmccann benmccann marked this pull request as ready for review December 1, 2025 21:07
@Rich-Harris Rich-Harris merged commit 5b5f688 into main Dec 2, 2025
18 checks passed
@Rich-Harris Rich-Harris deleted the fix/print-types branch December 2, 2025 17:52
@manuel3108
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants