Fixing partial float detection - #46
Merged
Merged
Conversation
In GemStone `Float fmin` = `5E-324`. In Pharo it is `5.0E-324`. The issue is that both are floats and need to be detected as such. This fix allows for both to be recognized as floats.
Adding tested item into
Pharo does not recognize <int>E<int> format only with lower case e.
Owner
|
Nice catch, thank you ! |
My pleasure! I was scratching my had when I had the first result of this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In GemStone
Float fmin=5E-324. In Pharo it is5.0E-324. The issue is that both are floats and need to be detected as such. This fix allows for both to be recognized as floats.