fix: add patches to Docusaurus for until they're merged upstream - #89
Merged
Conversation
When the client is configured to use a different font-size than the default (i.e. on the OS or in browser settings) the external link icon became disproportionately sized relative to the text. This converts the hardcodes pixel values to rem. I wrote a patch for it for Docusaurus. See: facebook/docusaurus#12336 This can be reverted when/if it's merged and deployed upstream.
In Markdown/MDX, any special characters between inline code should be displayed literally. The problem at hand was HTML tags, but this would apply to underscores, colons, etc. as well. The description was being mangled before, for example: "… of `<hn>` tags for headings." → "… of `` tags for headings." Now we correctly set the description: "… of <hn> tags for headings." → "… of <hn> tags for headings." It might've be better if we parsed the content character by character, and just skipped the pointer to after the inline code when found, but that'd be a drastic change for little benefit. Instead, I took the marker approach proposed by Sébastien Lorber—using U+FFFE and U+FFFF. I settled on them since they are "not characters" so we shouldn't encounter them organically. See: https://en.wikipedia.org/wiki/Specials_(Unicode_block) I've opened a PR upstream to fix this. This can be removed when/if it's merged in Docusaurus: facebook/docusaurus#11821
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit message(s).
I'm eager to have these fixed on prod already since I don't know when or if the PRs will actually get merged, and the search experience is pretty poor at the moment without this.
There were workarounds for this:
However, I wanted to match my PR so that the patches could be more thoroughly tested.
Related