fix(makernotes): delete the fabricated Google MakerNote parser - #421
Merged
Conversation
src/parsers/tiff/makernotes/google.rs registered a numeric TIFF-IFD MakerNote table for Make="Google" and emitted Astrophotography, ColorPop, FaceRetouching, HDRPlusMode, MergedFrameCount, NightSight, NightSightExposureTime, SceneDetection, SuperResZoom under the Google: group. None of these names appear in any ExifTool 13.59 source file (verified with grep -r "Name => '<TagName>'" against the full lib/ tree). ExifTool's only Google MakerNote table is Google::HDRPlusMakerNote, which is not a numeric TIFF IFD at all: it's string-ID keyed (e.g. '1-1', '9-36-1') and decodes a base64+encrypted+gzipped protobuf blob. Its real tags (ImageName, ImageData, TimeLogText, SummaryText, FrameCount, CreateDate) are not implemented by the deleted parser either -- this was a structurally wrong, 100% invented table, not a wrong-id bug. Follows the Qualcomm precedent (cdc643f, #345): delete the parser and its integration test, drop the `pub mod google` declaration and dispatcher arm, and leave an explanatory comment in their place. Confirmed no other code references the deleted symbols; cargo build, cargo test --workspace --lib, cargo fmt, and cargo clippy are all clean. google.rs exposed no cbindgen FFI symbols, so api/oxidex.h is unaffected.
# Conflicts: # src/parsers/tiff/makernote_dispatcher.rs # src/parsers/tiff/makernotes/mod.rs # src/parsers/tiff/makernotes/registries/mod.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/parsers/tiff/makernotes/google.rsregistered a numeric TIFF-IFD MakerNote table forMake="Google"and emittedAstrophotography, ColorPop, FaceRetouching, HDRPlusMode, MergedFrameCount, NightSight, NightSightExposureTime, SceneDetection, SuperResZoomunder theGoogle:group. None of these names appear in any ExifTool 13.59 source file (verified withgrep -r "Name => '<TagName>'"against the fulllib/tree).Google::HDRPlusMakerNote, which is not a numeric TIFF IFD at all: it's string-ID keyed (e.g.'1-1','9-36-1') and decodes a base64+encrypted+gzipped protobuf blob. Its real tags (ImageName,ImageData,TimeLogText,SummaryText,FrameCount,CreateDate) are not implemented by the deleted parser either — this was a structurally wrong, 100% invented table, not a wrong-id bug.cdc643f5, refactor(makernotes): delete fabricated Qualcomm MakerNote table #345): delete the parser and its integration test, drop thepub mod googledeclaration and dispatcher arm, and leave an explanatory comment in their place.Test plan
cargo build --libcargo test --workspace --lib(clean, no failures)cargo fmt --allcargo clippy --workspace --lib(clean)google.rsexposed no cbindgen FFI symbols, soapi/oxidex.his unaffected