ci: run build/lint/type-check/test on every pull request - #127
Merged
Conversation
The repo previously had no general PR CI — the only pull_request workflow was the path-filtered dep-changeset check, so PRs (fork or internal) merged with zero automated verification. This mirrors the gates release.yml runs on develop, plus bun test. Fork-safe: pull_request runs from forks get no secrets and a read-only token; setup-repo needs neither. Linear: API-2963 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
towanTG
marked this pull request as ready for review
July 28, 2026 11:31
- timeout-minutes caps compute abuse - persist-credentials: false keeps the token out of .git config - pinned bun 1.3.13 (matches packageManager) instead of latest - bun install --frozen-lockfile so dependency resolution cannot shift without a visible lockfile diff Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem (API-2963)
Fork PRs could never go green — but the root cause is broader than the fork-approval setting: this repo had no general PR CI at all. The only
pull_requestworkflow isenforce-dep-changeset.yml, path-filtered topackages/*/package.json. #122 merged today with zero automated checks (verified locally instead); #111/#108/#101 sit unverifiable.Fix
Adds
ci.yml:bun build:ci→bun lint→bun type-check:ci→bun teston every PR, mirroring the gatesrelease.ymlalready runs on develop pushes, plus tests. Reuses the existingsetup-repocomposite action.Fork-safety:
pull_request-triggered runs from forks receive no secrets and a read-onlyGITHUB_TOKEN;setup-repo(bun + node +bun install) needs neither. Nopull_request_targetanywhere, so there is no secret-exposure surface to weigh.Remaining (repo settings — admin action, decision to record on the task)
Settings → Actions → Fork pull request workflows: switch to "Require approval for first-time contributors" (from "all outside collaborators"). With no secrets in the workflow the residual risk is compute abuse only, which first-time-contributor approval still covers.
Proof plan
After merge + the settings flip: approve/trigger a run on fork PR #111 or #108 and confirm the checks report.
Linear: API-2963
🤖 Generated with Claude Code