Skip to content

build: Update swc_core to v74.0.0#646

Merged
kdy1 merged 6 commits into
mainfrom
kdy1/core
Jul 18, 2026
Merged

build: Update swc_core to v74.0.0#646
kdy1 merged 6 commits into
mainfrom
kdy1/core

Conversation

@kdy1

@kdy1 kdy1 commented Jul 18, 2026

Copy link
Copy Markdown
Member

No description provided.

kdy1 added 6 commits July 18, 2026 13:10
Releases:
  @swc/plugin-react-remove-properties@12.17.0
  @swc/plugin-styled-components@12.17.0
  @swc/plugin-transform-imports@12.17.0
  @swc/plugin-swc-confidential@11.17.0
  @swc-contrib/mut-cjs-exports@14.17.0
  @swc/plugin-remove-console@12.17.0
  @swc/plugin-experimental-feature-flags@0.16.0
  @swc/plugin-styled-jsx@13.17.0
  @swc/plugin-swc-magic@12.17.0
  @swc/plugin-formatjs@9.17.0
  @swc/plugin-prefresh@12.17.0
  @swc/plugin-emotion@14.17.0
  @swc/plugin-swc-sdk@12.17.0
  @swc/plugin-relay@12.17.0
  @swc-contrib/plugin-graphql-codegen-client-preset@0.29.0
  @swc/plugin-jest@12.17.0
  @swc/plugin-loadable-components@11.17.0
  @swc/plugin-noop@12.17.0

[skip ci]
@changeset-bot

changeset-bot Bot commented Jul 18, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 90ebd5c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@claude

claude Bot commented Jul 18, 2026

Copy link
Copy Markdown

PR Review — build: Update swc_core to v74.0.0

Thanks for keeping the plugins in sync with core. This is a mechanical dependency bump and looks clean overall. A few notes:

✅ Looks good

  • Workspace Cargo.toml versions bumped consistently (swc_core 73→74, swc_atoms 9→10, swc_common 23→24, the swc_css_* / swc_ecma_* families, testing, etc.), and Cargo.lock was regenerated — verified swc_core = 74.0.0 and swc_atoms = 10.0.0 resolved in the lockfile.
  • Per-package version / package.json / CHANGELOG.md bumps and changeset entries are present and consistent across all 20+ plugins.
  • No .rs changes needed, which is a good signal that v74 is source-compatible for these transforms.

🔎 Points worth confirming / minor nits

  1. scripts/bump-crates.shgenerate-lockfile runs after the commit.

    cargo mono bump $@
    git commit -a -m "Bump crates" || true
    
    cargo generate-lockfile

    cargo generate-lockfile runs after git commit -a, so any Cargo.lock changes it produces are left uncommitted by the script. If the intent is for the regenerated lockfile to land in the bump commit, move generate-lockfile before the commit (and let -a pick it up), e.g.:

    cargo mono bump $@
    cargo generate-lockfile
    git commit -a -m "Bump crates" || true

    Otherwise the lockfile has to be committed as a separate manual step (which is presumably what happened for this PR).

  2. Missing trailing newline in scripts/bump-crates.sh (\ No newline at end of file). Minor, but worth adding one to keep POSIX-friendly / avoid lint noise.

  3. Major core bump = host ABI expectations. Since swc_core had a major bump (73→74), the compiled .wasm plugins will require a host swc/@swc/core runtime compatible with the v74 plugin ABI. The package versions are bumped only as minor — worth double-checking that's the intended semver signal for consumers, given plugin/host version mismatches are a common source of runtime errors for users.

  4. CI is the real gate here. With a major core bump and no code changes, the confidence comes entirely from the build + snapshot tests passing. Please make sure the full workspace cargo build/test and the plugin snapshot suites are green before merging.

Nothing blocking from a code-quality standpoint — items #1 and #2 are the only concrete fix suggestions, and both are in the bump script rather than the shipped plugins.

@kdy1
kdy1 enabled auto-merge (squash) July 18, 2026 04:13
@kdy1
kdy1 merged commit 7d11cfc into main Jul 18, 2026
11 checks passed
@kdy1
kdy1 deleted the kdy1/core branch July 18, 2026 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant