compat: add Hostile Neural Networks deterministic recipe integration - #59
Conversation
There was a problem hiding this comment.
Code Review
This pull request integrates Hostile Neural Networks (HNN) compatibility into the Auto Storage mod's Compat Kit, resulting in an intentional fail-closed outcome (Outcome C) with zero registered custom recipe families or stations. The integration includes a new isolated GameTest fixture, updates to the compatibility matrix (raising the expected recipe count to 11,687), and comprehensive documentation. The review feedback correctly identifies a vulnerability in the isolated GameTest assertions where checking only the path prefix of registered IDs could allow namespace-prefixed registrations (e.g., hostilenetworks:sim_chamber) to bypass the fail-closed check, and suggests a robust fix to check both namespace and path.
c61ac27 to
5769dcd
Compare
Audit 6.5.0 Simulation Chamber / Loot Fabricator candidates as unsafe without a deterministic transaction contract (outcome C), register an empty present-mod module, and lock the boundary with fixture, matrix, and CI gates. via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
5769dcd to
2a76c70
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2a76c7015c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Closes #56.
Evidence-backed Outcome C (fail-closed) for Hostile Neural Networks
6.5.0, rebased onto currentmainthrough Actually Additions (#60) and bounded Craftable retained state (#80):HNNRecipeProvider/LootFabRecipesurfaces migrate to datagen / client-viewer buckets).hostilenetworksrecipe-inventory digest; fixture verifies it; combined coexistence/unclaimed digests stay matrix-report-only.Umbrella: #33.
Artifact
6.5.0ZbsbtrNEmaven.modrinth:hostile-neural-networks:ZbsbtrNE1fbe3fe6136fdd7938e176814c5d205f2d1c119743807b331e2f436513def357maven.modrinth:placebo:1Ypo4tf4(SHA-2561a844a5b081813b1edb82656329e54d38389ed470f6a6516a5887f5303d7daad)54a1d8e15abc215e164b2247d7a3b72ad0310ebecompat/audits/hostilenetworks/6.5.0.json(scanner format 16)compat/contracts/hostilenetworks.jsonhostilenetworks:*recipes →ca855354ff4d4e15f035911436d46a21721df92510463798ed6c5aef6a3038c6Audit decisions
HNNRecipeProvider(datagen);LootFabRecipe(client JEI helper).rollPredictions(RandomSource)+ live model/energy/inventory); Loot Fabricator (liveFabSelection/ config FE); Data Center multiblock composition of those behaviors.Review follow-ups
id.getNamespace().equals("hostilenetworks")and path prefix (TDD RED→GREEN viatest_hostilenetworks_fail_closed_boundary_is_locked).ShapedRecipe/ShapelessRecipe; matrix explicitly rejects Simulation Chamber, Loot Fabricator, and Data Center descriptor IDs.IsolatedRecipeInventoryEvidence.assertMatchesDescriptor; coexistence evidence remains descriptor-generic.Tests and exact results
./gradlew runHostilenetworksGameTestServer→ SelfTest 204,927; GameTest 4/4 passedbuild/compat-kit/hostilenetworks-latest-report.jsonstatus=passed, 12/12 checks acrossbuild, base GameTest, recipe-addon GameTest, HNN GameTest, and matrix./gradlew runCompatibilityMatrixGameTestServer→ 3/3 passed;recipes=16,389, prepare15.946 ms, shared retained2,829,720 B, per-menu116,283 B./gradlew runData→ BUILD SUCCESSFUL; no generated-resource driftPYTHONDONTWRITEBYTECODE=1 python3 -m unittest discover scripts→ 560/560 passedgit diff --check→ cleanDocs
docs/hostilenetworks-compatibility.mdmain; this module does not rewrite peer/global evidence.Remaining risks
Compat Kit report
build/compat-kit/hostilenetworks-latest-report.jsonA/B/C/D outcome
C — evidence-backed fail-closed present-mod integration (not an empty forever-RED adapter).
Test plan
via HAPI