Skip to content

compat: add Hostile Neural Networks deterministic recipe integration - #59

Merged
swear01 merged 2 commits into
mainfrom
compat/issue-56-hostilenetworks
Aug 2, 2026
Merged

compat: add Hostile Neural Networks deterministic recipe integration#59
swear01 merged 2 commits into
mainfrom
compat/issue-56-hostilenetworks

Conversation

@swear01

@swear01 swear01 commented Aug 1, 2026

Copy link
Copy Markdown
Owner

Summary

Closes #56.

Evidence-backed Outcome C (fail-closed) for Hostile Neural Networks 6.5.0, rebased onto current main through Actually Additions (#60) and bounded Craftable retained state (#80):

  • Compat Kit scanner-format-16 audit finds zero actual recipe classes (legacy format-7 HNNRecipeProvider / LootFabRecipe surfaces migrate to datagen / client-viewer buckets).
  • Present-mod module loads and registers zero stations/families via the public modular SDK only.
  • Descriptor/contract own the isolated hostilenetworks recipe-inventory digest; fixture verifies it; combined coexistence/unclaimed digests stay matrix-report-only.
  • No shared workflow lists, global committed digests, or peer-module evidence edits.

Umbrella: #33.

Artifact

Field Value
Version 6.5.0
Modrinth ZbsbtrNE
Maven maven.modrinth:hostile-neural-networks:ZbsbtrNE
SHA-256 1fbe3fe6136fdd7938e176814c5d205f2d1c119743807b331e2f436513def357
Runtime companion Placebo maven.modrinth:placebo:1Ypo4tf4 (SHA-256 1a844a5b081813b1edb82656329e54d38389ed470f6a6516a5887f5303d7daad)
Official source commit 54a1d8e15abc215e164b2247d7a3b72ad0310ebe
Audit compat/audits/hostilenetworks/6.5.0.json (scanner format 16)
Contract compat/contracts/hostilenetworks.json
Isolated digest 30 unconditional hostilenetworks:* recipes → ca855354ff4d4e15f035911436d46a21721df92510463798ed6c5aef6a3038c6

Audit decisions

  • Audited recipe classes: none (format 16).
  • Removed legacy non-recipe surfaces: HNNRecipeProvider (datagen); LootFabRecipe (client JEI helper).
  • Outside candidates / fail-closed: Simulation Chamber (rollPredictions(RandomSource) + live model/energy/inventory); Loot Fabricator (live FabSelection / config FE); Data Center multiblock composition of those behaviors.

Review follow-ups

  • Addressed Gemini high finding: isolated GameTest checks both id.getNamespace().equals("hostilenetworks") and path prefix (TDD RED→GREEN via test_hostilenetworks_fail_closed_boundary_is_locked).
  • Replaced vacuous transaction evidence with real base/typed-family shortage, capacity rollback, and checked-overflow markers.
  • Descriptor compile dependencies now include exact target plus reachable Jade, Placebo, and JEI common API ancestry; runtime remains target + Placebo only.
  • Fixture locks exactly 30 HNN recipes to vanilla ShapedRecipe/ShapelessRecipe; matrix explicitly rejects Simulation Chamber, Loot Fabricator, and Data Center descriptor IDs.
  • Fixture also calls IsolatedRecipeInventoryEvidence.assertMatchesDescriptor; coexistence evidence remains descriptor-generic.

Tests and exact results

  • ./gradlew runHostilenetworksGameTestServer → SelfTest 204,927; GameTest 4/4 passed
  • Compat Kit bundled verify → build/compat-kit/hostilenetworks-latest-report.json status=passed, 12/12 checks across build, base GameTest, recipe-addon GameTest, HNN GameTest, and matrix
  • ./gradlew runCompatibilityMatrixGameTestServer3/3 passed; recipes=16,389, prepare 15.946 ms, shared retained 2,829,720 B, per-menu 116,283 B
  • ./gradlew runData → BUILD SUCCESSFUL; no generated-resource drift
  • PYTHONDONTWRITEBYTECODE=1 python3 -m unittest discover scripts560/560 passed
  • Focused HNN static regression → passed
  • exact target SHA/size plus all four audited ancestry artifacts verified
  • JSON parse checks and git diff --check → clean

Docs

  • New/updated docs/hostilenetworks-compatibility.md
  • Shared README, notes, overview, plan, roadmap, recipe-family API, workflow, and matrix Java remain current main; this module does not rewrite peer/global evidence.

Remaining risks

  • Simulation Chamber and Loot Fabricator remain unsupported until a complete non-random, non-live-BE transaction contract exists.
  • Twilight Forest-conditioned living-matter recipes stay absent without that mod; they are not a custom family gap.
  • Representative fixture versions are CI evidence only, not player-facing exact pins.
  • Matrix timing remains host/JIT-sensitive, but this latest local run passed the unchanged 50 ms gate at 15.946 ms and the retained-state gates with wide margin; Linux CI remains authoritative.

Compat Kit report

build/compat-kit/hostilenetworks-latest-report.json

A/B/C/D outcome

C — evidence-backed fail-closed present-mod integration (not an empty forever-RED adapter).

Test plan

  • Compat Kit audit/contract committed; format-16 migration preserved
  • RED then GREEN Hostilenetworks fixture (4) + namespace fail-closed regression
  • Compat Kit verify 12/12
  • HNN fixture + compatibility matrix + build + runData + Python 560
  • Latest-head Codex review completed; its sole shared-doc suggestion was resolved as non-actionable under [Infrastructure] isolate module evidence and generated compatibility summaries #77 evidence isolation; remote CI passed

via HAPI

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request integrates Hostile Neural Networks (HNN) compatibility into the Auto Storage mod's Compat Kit, resulting in an intentional fail-closed outcome (Outcome C) with zero registered custom recipe families or stations. The integration includes a new isolated GameTest fixture, updates to the compatibility matrix (raising the expected recipe count to 11,687), and comprehensive documentation. The review feedback correctly identifies a vulnerability in the isolated GameTest assertions where checking only the path prefix of registered IDs could allow namespace-prefixed registrations (e.g., hostilenetworks:sim_chamber) to bypass the fail-closed check, and suggests a robust fix to check both namespace and path.

@swear01
swear01 force-pushed the compat/issue-56-hostilenetworks branch from c61ac27 to 5769dcd Compare August 2, 2026 16:42
@swear01
swear01 marked this pull request as ready for review August 2, 2026 16:42
swear01 and others added 2 commits August 3, 2026 03:53
Audit 6.5.0 Simulation Chamber / Loot Fabricator candidates as unsafe
without a deterministic transaction contract (outcome C), register an
empty present-mod module, and lock the boundary with fixture, matrix,
and CI gates.

via [HAPI](https://hapi.run)

Co-Authored-By: HAPI <noreply@hapi.run>

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
via [HAPI](https://hapi.run)

Co-Authored-By: HAPI <noreply@hapi.run>

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@swear01
swear01 force-pushed the compat/issue-56-hostilenetworks branch from 5769dcd to 2a76c70 Compare August 2, 2026 20:01
@swear01

swear01 commented Aug 2, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2a76c7015c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/hostilenetworks-compatibility.md
@swear01
swear01 merged commit e83b865 into main Aug 2, 2026
1 check passed
@swear01
swear01 deleted the compat/issue-56-hostilenetworks branch August 4, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Compatibility] Hostile Neural Networks deterministic recipe integration

1 participant