compat: add Draconic Evolution deterministic recipe integration - #69
Conversation
There was a problem hiding this comment.
Code Review
This pull request integrates Draconic Evolution compatibility into the Auto Storage mod using the Compat Kit. It audits Draconic Evolution's recipes and establishes a fail-closed boundary (outcome C) for its Fusion Crafting due to its reliance on live multiblock states, injector-local energy charging, and config-timed durations. The PR introduces a new draconicevolutionFixture with 6 GameTests, updates the compatibility matrix to load 14 optional mods (increasing the expected recipe count to 11,837), adds corresponding documentation, and integrates the new test task into the GitHub Actions workflows and Python test scripts. There are no review comments, and I have no feedback to provide.
Audit ATM10 Draconic Evolution 3.1.4.632 and register a present-mod module that keeps Fusion Crafting fail-closed while preserving namespace vanilla crafting through built-ins. via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Regenerate exact target, source, recipe, and reachable ancestry evidence. Remove legacy name-shaped non-recipe candidates while preserving the fail-closed Fusion Crafting decision and descriptor-owned matrix. via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Update current-main integration status and the 13,067-recipe matrix evidence after Create Aquatic Ambitions merged. via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
26f0b45 to
c39dc5f
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c39dc5fce9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Remove the unrequested inline rationale; the fail-closed decision remains in the active compatibility documentation. via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0a23fa8d8f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Refresh the no-op adapter provenance and add a regression that checks every generated-file digest in the module manifest. via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Closes #63.
Adds an evidence-backed Outcome C (fail closed) module for Draconic Evolution
3.1.4.632. The current Compat Kit scanner-format-16 audit identifies one actual runtime recipe class,FusionRecipe, and rejects it because Fusion Crafting is a live multiblock process that cannot be reduced to Auto Storage's deterministic resource transaction contract. When the target mod is present, the module loads exactly once and registers zero stations, resource kinds, or recipe families.Exact representative artifact
3.1.4.632lBMsiWywmaven.modrinth:draconic-evolution:lBMsiWyw623d7d58e58428a206015b56bf67387c79ff6d97f7221cff23b1dad0bed9544ed297c2657cefa6ac2af19a96ee12a51ab07d36f556nwe5IX, CodeChicken LibgQ1srSKhFormat-16 audit
FusionRecipe, manually rejected.Rejection boundary
Fusion Crafting depends on all of the following live state:
DEConfigcharge and craft timing;Ingredient/StackIngredientpayloads;IFusionDataTransferassembly.Auto Storage therefore does not reinterpret fusion energy as FE, Fuel, or station work and does not expose a partial approximation.
Runtime and matrix boundary
draconicevolution.3044e680…f5c6.Verification on head
c8c1b36runDraconicevolutionGameTestServer: 6/6 required tests.runCompatibilityMatrixGameTestServer: 3/3 required tests.git diff --check: clean.Documentation
docs/draconicevolution-compatibility.md.Remaining risk
Fusion Crafting intentionally remains unsupported until a generic retained-multiblock, tiered-injector, exact-energy, and config-timed process contract exists.
via HAPI
Co-Authored-By: HAPI noreply@hapi.run
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com