compat: add Advanced AE deterministic recipe integration - #73
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request integrates Advanced AE (version 1.6.11-1.21.1) as a fail-closed compatibility module. All 12 recipe-class candidates (including the Reaction Chamber) are rejected because they rely on live AE-network state rather than a deterministic transaction model. The changes add a new compat module, a dedicated GameTest fixture with 8 tests, and update the compatibility matrix (raising the benchmark recipe count to 11,742). Documentation, CI workflows, and the GeckoLib dependency (updated to 4.8.2) have been updated accordingly. There are no review comments, so no feedback is provided.
Audit ATM10 representative Advanced AE and reject Reaction Chamber plus datagen/viewer helpers; present-mod fixture proves zero custom families. via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
9cac3dd to
db7bce6
Compare
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: db7bce620f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Rebuild the reviewed audit from the exact target, source, and reachable ancestry; reopen and reject Reaction Chamber under the current contract. via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Rebase onto main with #73/#70 requires a Create namespace inventory digest that includes Aquatic Ambitions and Immersive Engineering together; keep peer digests that already matched. via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Capture the 034c96e rebase evidence, 13,412-recipe matrix metrics, and local craftable-prepare contention notes after #73/#70 landed. via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Coexistence with Advanced AE and Create Aquatic Ambitions adds one more enderio-namespace recipe, so lock the measured 1448-recipe inventory digest. Co-authored-by: Cursor <cursoragent@cursor.com>
Coexistence with Advanced AE and Create Aquatic Ambitions adds one more enderio-namespace recipe, so lock the measured 1448-recipe inventory digest. Co-authored-by: Cursor <cursoragent@cursor.com>
Coexistence with Advanced AE and Create Aquatic Ambitions adds one more enderio-namespace recipe, so lock the measured 1448-recipe inventory digest. Co-authored-by: Cursor <cursoragent@cursor.com>
Coexistence with Advanced AE and Create Aquatic Ambitions adds one more enderio-namespace recipe, so lock the measured 1448-recipe inventory digest. Co-authored-by: Cursor <cursoragent@cursor.com>
1 participant
Summary
Closes #65.
Evidence-backed Outcome C (fail-closed) for Advanced AE
1.6.11-1.21.1: current Compat Kit format-16 evidence identifies the Reaction Chamber as the only actual target recipe candidate and rejects it. The present-mod module loads and registers zero stations, recipe families, and resource kinds. Vanilla-class recipes and AE2 Inscriber recipes remain owned by the existing built-in / AE2 integrations.Umbrella: #33.
Artifact
1.6.11-1.21.1lHSZ2gYImaven.modrinth:advancedae:lHSZ2gYI891e1f8ee0f3ac1bbce03fc2848b761f9c52bea4533eb3419ae849582e15ced7pedroksl/AdvancedAEtag1.6.11-1.21.1-neoforge@9378212e1fc81930c1fe914c9d8a9a130b34e2b219.2.17, GuideMErduAfwb7, GeckoLibRVIo5f6E(4.8.2)Current audit boundary
ReactionChamberRecipe; rejected after migration reopened the decision.advanced_aeto SHA-2560adc34a90c85458883b43ae02cbc4d4522e0f4f63678d5423da1938606f3ee94. Nineteen jar JSON files requiring unavailable AE2WTLib serializers do not enter the server RecipeManager.TDD and current local evidence
migrate-auditrejected the legacy audit without exact ancestry.migrate-contractreopenedReactionChamberRecipe; it was manually re-reviewed and rejected.runAdvancedAeGameTestServerrunCompatibilityMatrixGameTestServerbuildstageAe2CompatAuditAncestry1.1.24+1.21.1runDatagit diff --checkMatrix performance: first Craftable 0.856 ms; switch p95 0.587 ms; shared index 8,739,080 bytes; per-menu 114,638 bytes.
Docs
docs/advanced-ae-compatibility.mdReview gate
f94d3946b065302caa54474265e3e3ac882bf493