fix: handle nested classes under anonymous owners by swear01 · Pull Request #82 · swear01/Auto_Storage

swear01 · 2026-08-02T22:13:06Z

Summary

Closes Compat Kit: exclude named nested classes under anonymous owners #81 and unblocks the exact Immersive Engineering audit migration in [Compatibility] Immersive Engineering deterministic recipe integration #53.
Rebased on current main including XyCraft Machines 7efddd0.
Makes nested-class source addressability depend on the complete InnerClasses owner chain.
Excludes a named child below any anonymous/local/synthetic owner instead of inventing a source-level name.
Preserves legal top-level $ identifiers and ordinary named nested classes.
Bumps the candidate-classifier cache namespace from 2 to 3 so pre-fix evidence cannot be reused.

Strict TDD

RED on current main:

PYTHONDONTWRITEBYTECODE=1 python3 -m unittest \
  scripts.test_compat_kit.CompatKitAuditTests.test_named_nested_class_under_anonymous_owner_is_handled_without_invented_source_name

ValueError: named nested class owner is unresolved: samplemod.client.ModelConveyor$1$Key

GREEN after the fix:

focused regression: 1/1 passed;
nested-class/cache group: 4/4 passed;
./gradlew stageAe2CompatAuditAncestry + python3 -m unittest scripts.test_compat_kit: 211/211 passed;
PYTHONDONTWRITEBYTECODE=1 python3 -m unittest discover scripts: 566/566 passed;
./gradlew build --console=plain --no-daemon: BUILD SUCCESSFUL;
git diff --check: clean.

Documentation

Updates docs/compat-kit.md and docs/addon-development.md with the owner-chain/source-addressability rule and classifier version.

Remaining risk

This PR intentionally changes scanner evidence only. The representative IE artifact must be rescanned and manually reviewed in [Compatibility] Immersive Engineering deterministic recipe integration #53 after merge; no old candidate count may be reused.

swear01 · 2026-08-02T22:13:16Z

@codex review

gemini-code-assist

Code Review

This pull request updates the compatibility kit scanner to exclude named nested classes whose ownership chain passes through an excluded class (such as anonymous, local, or synthetic classes). This is implemented in tools/compat-kit/compat_kit.py by recursively checking the outer class ancestry in _is_inspectable_class and bumping the CANDIDATE_CLASSIFIER_VERSION to 3. The documentation in docs/addon-development.md and docs/compat-kit.md has been updated to reflect this change, and a new unit test has been added to scripts/test_compat_kit.py to verify the behavior. There are no review comments, and I have no feedback to provide.

via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eba4ddce36

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

swear01 · 2026-08-02T22:24:25Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9e8e9c35f0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Persist classifier semantics as scanner format 17 so format-16 evidence cannot be reused as current. Resolve nested ownership iteratively with per-archive memoization and an explicit 1,024-level bound. via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Fail closed when a named nested class references an owner outside its own archive, preventing excluded owner chains from being reconstructed differently across classpath jars. Update current format documentation and add the split-archive regression. via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

swear01 · 2026-08-02T23:15:53Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 082a557bbc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Capture the persisted-format, bounded traversal, and same-archive fail-closed lessons from the latest Compat Kit review. via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

swear01 · 2026-08-02T23:26:44Z

@codex review

Keep the repository overview and structure map consistent with the migrated format-17 AE2 evidence. via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

swear01 · 2026-08-02T23:31:05Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b8ec682937

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Classify abstract BlockEntity descendants before name terms, invalidate the prior classifier cache, and make committed complete-contract audits fail when they remain on a legacy scanner format. via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Validate legacy audit structure and artifact identity without applying the current classifier before the exact current-format rescan. via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

swear01 · 2026-08-03T01:17:02Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 00ff21c2f9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Derive deeply nested source classes iteratively and reject ownership chains beyond the scanner limit. via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

swear01 · 2026-08-03T01:39:47Z

@codex review

swear01 · 2026-08-03T01:42:26Z

@codex review

chatgpt-codex-connector · 2026-08-03T01:51:04Z

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: de347c69e5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

gemini-code-assist Bot reviewed Aug 2, 2026

View reviewed changes

fix: handle nested classes under anonymous owners

9e8e9c3

via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

chatgpt-codex-connector Bot reviewed Aug 2, 2026

View reviewed changes

Comment thread tools/compat-kit/compat_kit.py Outdated

Comment thread tools/compat-kit/compat_kit.py Outdated

swear01 force-pushed the fix/compat-kit-anonymous-owner-nested-class branch from eba4ddc to 9e8e9c3 Compare August 2, 2026 22:24

chatgpt-codex-connector Bot reviewed Aug 2, 2026

View reviewed changes

Comment thread tools/compat-kit/compat_kit.py Outdated

Comment thread docs/compat-kit.md Outdated

swear01 and others added 2 commits August 3, 2026 07:00

chatgpt-codex-connector Bot reviewed Aug 2, 2026

View reviewed changes

Comment thread docs/ae2-compatibility.md

docs: record nested owner audit boundary

2b82b04

Capture the persisted-format, bounded traversal, and same-archive fail-closed lessons from the latest Compat Kit review. via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

docs: align AE2 scanner format references

b8ec682

Keep the repository overview and structure map consistent with the migrated format-17 AE2 evidence. via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

chatgpt-codex-connector Bot reviewed Aug 2, 2026

View reviewed changes

Comment thread tools/compat-kit/compat_kit.py

swear01 and others added 8 commits August 3, 2026 08:06

chore(compat): migrate six audits to scanner format 17

c84b617

via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

fix(compat): compare legacy classifier migrations

2bd61b0

via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

chore(compat): migrate six audits to format 17

4388042

via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

chore(compat): refresh AE2 classifier evidence

07999c4

via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

chore(compat): refresh classifier 4 audit evidence

7344035

via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

test(compat): require format 17 module evidence

00ff21c

via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

chatgpt-codex-connector Bot reviewed Aug 3, 2026

View reviewed changes

Comment thread tools/compat-kit/compat_kit.py

fix(compat-kit): bound nested source mapping

de347c6

Derive deeply nested source classes iteratively and reject ownership chains beyond the scanner limit. via [HAPI](https://hapi.run) Co-Authored-By: HAPI <noreply@hapi.run> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

swear01 merged commit 5d757d7 into main Aug 3, 2026
1 check passed

swear01 deleted the fix/compat-kit-anonymous-owner-nested-class branch August 3, 2026 01:59

This was referenced Aug 3, 2026

[Compatibility] Audit and expand deterministic support for ATM10 1.21.1 #33

Open

fix: persist selected mod ID across Compat Kit audits #84

Merged

compat: add Integrated Dynamics + Integrated Crafting deterministic recipe integration #51

Merged

Conversation

swear01 commented Aug 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Strict TDD

Documentation

Remaining risk

Uh oh!

swear01 commented Aug 2, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

swear01 commented Aug 2, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

swear01 commented Aug 2, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

swear01 commented Aug 2, 2026

Uh oh!

swear01 commented Aug 2, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

swear01 commented Aug 3, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

swear01 commented Aug 3, 2026

Uh oh!

swear01 commented Aug 3, 2026

Uh oh!

chatgpt-codex-connector Bot commented Aug 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

swear01 commented Aug 2, 2026 •

edited

Loading