Skip to content

Address some comments on PR/5048#19

Merged
swegner merged 2 commits into
swegner:merge_lukecwik_gradlefrom
lukecwik:gradle5
Apr 9, 2018
Merged

Address some comments on PR/5048#19
swegner merged 2 commits into
swegner:merge_lukecwik_gradlefrom
lukecwik:gradle5

Conversation

@lukecwik

@lukecwik lukecwik commented Apr 9, 2018

Copy link
Copy Markdown

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

lukecwik added 2 commits April 9, 2018 06:37
Update postcommit project paths.
Drop 'Gradle' from Python precommit PR trigger.
@swegner
swegner merged commit c73672d into swegner:merge_lukecwik_gradle Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants