Add a tip to the HOWTO for new message groups #1178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was surprised that these files weren't auto-generated, but listing this as an extra step will hopefully avoid confusion for developers adding new message groups in the future.
Contributor
Author
|
IMO this should probably be part of the code generation step, as it's really easy to forget adding this (and seemingly only caught if you add message specific tests - so luckily I did that!), so I added a couple of bugs to track: https://swift-nav.atlassian.net/browse/DEVINFRA-804?jql=issueKey%20in%20(DEVINFRA-803%2CDEVINFRA-804) |
silverjam
approved these changes
Jul 1, 2022
samvrlewis
added a commit
that referenced
this pull request
Jul 6, 2022
I was surprised that these files weren't auto-generated, but listing this as an extra step will hopefully avoid confusion for developers adding new message groups in the future.
samvrlewis
added a commit
that referenced
this pull request
Jul 6, 2022
I was surprised that these files weren't auto-generated, but listing this as an extra step will hopefully avoid confusion for developers adding new message groups in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was surprised that these files weren't auto-generated, but listing
this as an extra step will hopefully avoid confusion for developers
adding new message groups in the future.
API compatibility
Does this change introduce a API compatibility risk?
No