Add staging fixes to master #1185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upcoming ed25519 signature message requires a fixed array of size 64 which currently breaks the Rust build because Serde does not currently natively support serializing or deserialzing arrays with sizes larger than 32. The `serde-big-array` crates allows us to work around this issue by using macros defined there for larger arrays.
java: Add support for u32 arrays The generated Java code was missing some code to allow for u32 arrays, which is needed for the upcoming ed25519 signature message.
Also installs some dependencies to the Dockerfile so that json2test can run in the libsbp docker image.
I was surprised that these files weren't auto-generated, but listing this as an extra step will hopefully avoid confusion for developers adding new message groups in the future.
Contributor
Author
|
Unless there's any problems in doing so, I will rebase and merge this (once approved) to avoid any conflicts between staging/master that would be caused by squashing |
Contributor
Author
|
If I'm understanding correctly, looks like this needs #1179 to go in first - will wait for that to go in before merging. |
silverjam
approved these changes
Jul 6, 2022
notoriaga
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I merged PRs for some basic fixes into the staging branch, but I think I misunderstood the purpose of staging and these probably should've been merged directly into master. Opening this now to get the changes into master now.
Referenced PRs:
#1174
#1175
#1177
#1178
API compatibility
Does this change introduce a API compatibility risk?
No
JIRA Reference
https://swift-nav.atlassian.net/browse/BOARD-XXXX