[SO-17] Guillaume/so 7/add leader group message #824
Conversation
reimerix
left a comment
reimerix
left a comment
There was a problem hiding this comment.
Left a couple of comments - I think it would be good if the time source flags field would follow one convention throughout the SBP protocol, and since it was there first in MSG_IMU_RAW, I would tend to follow that convention, even if it admittedly makes less sense than your proposal.
As per Design Doc of new Starling Output MVP. The point of this message is to facilitate consumption of output data, in particular that of the fuzed Solution Group, aka "Fuzed Wagon".
Because MSG_GROUP_META introduces a new type (array of u16) that was not used before in any other sbp message, a dedicated parser must exist for the bindings to be built. Because buffering is always by chunks of u8, an array of u16 must be built from reading pairs of u8. Convention is always LittleEndian throughout the entire sbp protocol.
Use https://gist.github.com/silverjam/83a3376a6d639a4a57e2b9be4636f972 for more info on how to create such test. Also make sure the raw_json field has all fields in it. I left sbp-test-data into libsbp
GuillaumeDec
force-pushed
the
guillaume/so-7/add-leader-group-message
branch
from
7ed5f23 to
3ee5dd9
Compare
After much consideration, I agree with your suggestion, let's stick to the legacy. Not ideal perhaps, but the |
GuillaumeDec
changed the title
GuillaumeDec
changed the title
GuillaumeDec
changed the title
Add sbp definition of new leader/leading message for Solution Groups.
SBP_MSG_GROUP_META.
As per Design Doc of new Starling Output MVP.
The point of this message is to facilitate consumption of output data,
in particular that of the fuzed Solution Group, aka "Fuzed Wagon".
Could be used for the GNSS (ARP) Wagon too.
Had to update parsers for Rust & Javascript b/c a new type (array of u16 for the group_msgs field) was introduced.