python: remove generation of the sbp.jit _payload_size method #825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method was not used, and the genreated code wasn't correct when the message included an unsized member like a string or a variable sized array.
silverjam
changed the title
silverjam
requested review from
GuillaumeDec,
denisng and
denniszollo
and removed request for
denisng
Contributor
Author
|
@GuillaumeDec FYI, noticed this while reviewing your PR |
Contributor
Author
|
@GuillaumeDec since this is merged you'll need to merge and regenerate Python prior to merging your PR (#824) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method was not used, and the genreated code wasn't correct when the
message included an unsized member like a string or a variable sized
array.