Skip to content

Conversation

@dgburr
Copy link
Contributor

@dgburr dgburr commented Sep 26, 2020

The example message shown in Chapter 4 of the SBP Specification is incorrect - the message ID for MSG_BASELINE_ECEF is 523 = 20Bh, not 514 = 202h.

incorrect - the message ID for MSG_BASELINE_ECEF is 523 = 20Bh, not 514
= 202h.
@dgburr
Copy link
Contributor Author

dgburr commented Sep 26, 2020

Test code in case you want to double-check my checksum calculation:

import sbp.navigation
import binascii

msg = sbp.navigation.MsgBaselineECEF(sender=1228, tow=416300400, x=-4145, y=-5905, z=6384, accuracy=0, n_sats=5, flags=0)
b = binascii.hexlify(msg.to_binary())
pairs = [str(b[i:i+2]) for i in range(0, len(b), 2)]
print('\n'.join(pairs))

Copy link
Contributor

@denniszollo denniszollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm surprised we didn't catch this after deprecating MSG_POS_ECEF during SBP 2.0 revamp. Thanks so much for catching and fixing!

@dgburr
Copy link
Contributor Author

dgburr commented Sep 28, 2020

LGTM. I'm surprised we didn't catch this after deprecating MSG_POS_ECEF during SBP 2.0 revamp. Thanks so much for catching and fixing!

I didn't catch it - the problem was actually reported by a customer

@dgburr dgburr merged commit f688a21 into master Sep 28, 2020
@dgburr dgburr deleted the example-msg-fix branch September 28, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants