Prototype of new approach with support for bi-di streaming including trailers #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzBusch
force-pushed
the
fb-new-approach
branch
from
fbb6ac0 to
02936b5
Compare
gjcairo
approved these changes
Jul 3, 2025
Contributor
Author
|
Going to merge this for now to allow @gjcairo to iterate on it |
Lukasa
reviewed
Jul 7, 2025
Collaborator
There was a problem hiding this comment.
FWIW, I pretty strongly believe the use of spans here is inappropriate, so we should open up an API conversation on that point.
Contributor
Author
There was a problem hiding this comment.
I'm happy to change this but we don't yet have a canonical bag of bytes type. What would you use instead?
Contributor
Author
There was a problem hiding this comment.
I created an issue so we can track and discuss this https://github.com/swift-server/swift-http-server/issues/5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.