Add new HTTPServer product
#7
Conversation
|
|
||
| let package = Package( | ||
| name: "HTTPServer", | ||
| platforms: [.macOS("16")], |
There was a problem hiding this comment.
Won't the removal of the minimum version break the build?
There was a problem hiding this comment.
Everything should be properly availability annotated IIRC
There was a problem hiding this comment.
Not sure if I landed that though. @gjcairo you can check
There was a problem hiding this comment.
I don't see it eg in https://github.com/swift-server/swift-http-server/blob/main/Sources/HTTPServer/HTTPServer.swift, so I believe this won't currently build on main.
There was a problem hiding this comment.
Yeah this builds fine locally on my Mac, but fails on 6.1. There are annotations missing around Span. I was expecting some warnings to show up in Xcode but nope. I'll fix this up and get CI set up.
There was a problem hiding this comment.
Ah, there was an unsafe flag disabling the checks on Xcode :D I'll get rid of that too
No description provided.