Skip to content

Add new HTTPServer product #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gjcairo merged 1 commit into from
Aug 4, 2025
Merged

Add new HTTPServer product #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,11 @@ let extraSettings: [SwiftSetting] = [

let package = Package(
name: "HTTPServer",
platforms: [.macOS("16")],
Copy link

@czechboy0 czechboy0 Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't the removal of the minimum version break the build?

Copy link
Contributor

@FranzBusch FranzBusch Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything should be properly availability annotated IIRC

Copy link
Contributor

@FranzBusch FranzBusch Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I landed that though. @gjcairo you can check

Copy link

@czechboy0 czechboy0 Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see it eg in https://github.com/swift-server/swift-http-server/blob/main/Sources/HTTPServer/HTTPServer.swift, so I believe this won't currently build on main.

Copy link
Collaborator Author

@gjcairo gjcairo Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this builds fine locally on my Mac, but fails on 6.1. There are annotations missing around Span. I was expecting some warnings to show up in Xcode but nope. I'll fix this up and get CI set up.

Copy link
Collaborator Author

@gjcairo gjcairo Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, there was an unsafe flag disabling the checks on Xcode :D I'll get rid of that too

products: [
.library(
name: "HTTPServer",
targets: ["HTTPServer"])
],
dependencies: [
.package(url: "https://github.com/apple/swift-collections.git", from: "1.0.4"),
.package(url: "https://github.com/apple/swift-http-types.git", from: "1.0.0"),
Expand Down