localizedName_103036605() fails when the current date is around DST change #1562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hange We saw a test failure in this CI job: https://ci.swift.org/job/oss-swift-6.2-bootstrap-ubuntu-24_04-x86_64/318 ``` [2025-10-26T00:58:39.054Z] ✘ Test localizedName_103036605() recorded an issue at TimeZoneTests.swift:74:13: Expectation failed: (tz?.localizedName(for: .generic, locale: locale) → "Central European Time (Germany)") == (expected → "Central European Time") ``` The cause of this test failure is that this `TimeZone` API uses the current time as reference, and depending on `style` it may include the time zone city to disambiguate that from the [golden zone](https://www.unicode.org/reports/tr35/tr35-dates.html#Using_Time_Zone_Names) if the current time is close to a DST transition. Update the test to use the golden zone to opt out of this unexpected behavior since that is not what this test was meant to test. Also while we're here, update the test to respect the `style` argument.
|
@swift-ci PLEASE TEST |
|
Test failures are legitimate. Putting this back to draft |
parkera
approved these changes
Oct 28, 2025
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci please test |
The time zone offset for Vostok recently went through a change. Udpate the test to use a stable time zone for this test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We saw a test failure in this CI job: https://ci.swift.org/job/oss-swift-6.2-bootstrap-ubuntu-24_04-x86_64/318
The cause of this test failure is that this
TimeZoneAPI uses the current time as reference, and depending onstyleit may include the time zone city to disambiguate that from the golden zone if the current time is close to a DST transition.Update the test to use the golden zone to opt out of this unexpected behavior since that is not what this test was meant to test.
Also while we're here, update the test to respect the
styleargument.