Use the canonicalized name to create ICU timezone object #1616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ICU expects time zone identifiers to be IANA identifiers, such as "America/Los_Angeles". Hence names such as "UTC+9" aren't officially supported. There is a canonicalization function available, but I did not remember to use it when switching to the new ICU `uatimezone` SPI. Fix this by always using the canonicalized version to initiate an ICU timezone object. 164490980
Contributor
Author
|
@swift-ci please test |
jmschonfeld
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ICU expects time zone identifiers to be IANA identifiers, such as "America/Los_Angeles". Hence names such as "UTC+9" aren't officially supported.
There is a canonicalization function available, but I did not remember to use it when switching to the new ICU
uatimezoneSPI.Fix this by always using the canonicalized version to initiate an ICU timezone object.
164490980