jextract: Evaluate IfConfigDecl and add --static-build-config option 2#678
Merged
ktoso merged 17 commits intoswiftlang:mainfrom Apr 7, 2026
Merged
jextract: Evaluate IfConfigDecl and add --static-build-config option 2#678ktoso merged 17 commits intoswiftlang:mainfrom
ktoso merged 17 commits intoswiftlang:mainfrom
Conversation
Co-authored-by: Konrad `ktoso` Malawski <konrad.malawski@project13.pl>
Contributor
Author
|
Swift nightly seems to be failing consistently. |
Contributor
Author
|
Unless I missed something, everything seems to be working fine except nightly. |
ktoso
reviewed
Apr 7, 2026
| ], | ||
| resources: [ | ||
| .process("Resources") | ||
| ], |
Collaborator
There was a problem hiding this comment.
Hmmm resources cause pulling in Foundation but hopefully just for the specific target, so this won't show up in any of the runtime modules...
Please keep an eye out on it @madsodgaard but it seems our linking test is happy so we should be good 👍
ktoso
approved these changes
Apr 7, 2026
ktoso
approved these changes
Apr 7, 2026
Collaborator
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
Yeah I think I'm happy with the generation approach, it's kinda cleaner to be honest even.
Collaborator
|
I think we're good here AFAICS... 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IfConfigDeclsupport broke Android builds #676In the previous PR, the code generated by buildToolsPlugin wasn't being correctly referenced when the host and target OS differed (However, in some cases it was working 🤪).
It seems that SwiftPM starts the build process before the plugin completes its execution, even when a target explicitly depends on it 🤔.
To work around this, I’ve moved away from generating source code and instead load a JSON file as a resource.