build: make SQLite a private dependency
#109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Member
Author
|
@swift-ci please test |
tomerd
reviewed
Aug 10, 2020
Contributor
tomerd
left a comment
tomerd
left a comment
There was a problem hiding this comment.
not sure where the implications of these are
Member
Author
|
It basically means that users of |
Contributor
|
I'll defer to @abertelrud and @neonichu on this one |
Since the SQLite3 import is marked as `@_implementationOnly` this is perfectly reasonable to assume that the symbols from SQLite3 should not be required by consumers of this library and thus the consumers of this library do not need to link against SQLite3 themselves. Reflect this in the build. This is needed to ensure that the dependency handling works properly for building swift-driver.
Member
Author
|
@swift-ci please test |
neonichu
approved these changes
Aug 18, 2020
Contributor
|
I actually need this for something I'm working on, too. Thanks @compnerd! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the SQLite3 import is marked as
@_implementationOnlythis isperfectly reasonable to assume that the symbols from SQLite3 should not
be required by consumers of this library and thus the consumers of this
library do not need to link against SQLite3 themselves. Reflect this in
the build. This is needed to ensure that the dependency handling works
properly for building swift-driver.