improve process state management #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
requested review from
abertelrud,
aciidgh,
friedbunny and
neonichu
as code owners
Contributor
Author
|
@swift-ci test |
abertelrud
reviewed
Apr 2, 2021
abertelrud
reviewed
Apr 2, 2021
motivation: reports on hang process (mostly tests) changes: * refactor Process to use a state machine to track the process execution state * replace use of DispatchQueue with Locks to protect state rdar://76087764
tomerd
force-pushed
the
refactor/process-state
branch
from
7ab1fec to
ce7132b
Compare
Contributor
Author
|
@swift-ci please test |
tomerd
commented
Apr 2, 2021
Contributor
Author
|
@abertelrud thanks for the review, amended |
neonichu
approved these changes
Apr 2, 2021
abertelrud
approved these changes
Apr 2, 2021
Contributor
abertelrud
left a comment
abertelrud
left a comment
There was a problem hiding this comment.
Looks good to me now. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: reports on hang process (mostly tests)
changes:
rdar://76087764