Revert "improve process state management" #207
Conversation
This reverts commit e626b7e.
compnerd
requested review from
abertelrud,
aciidgh,
friedbunny,
neonichu and
tomerd
as code owners
|
@swift-ci please test |
|
cc @tomerd |
|
@swift-ci please test macOS platform |
|
13:18:55 [./swift/utils/build-script] ERROR: can't find CMake (please install CMake) That seems odd ... |
|
@swift-ci please test macOS platform |
|
@compnerd i'd be okay reverting temporarily since its an improvement only, but think its something we want to bring back once we understand the windows breakage. can you tell how it broke the windows build / give guidance on how i can test it for windows via ci? |
|
@tomerd the failure is in the log above (https://compnerd.visualstudio.com/3133d6ab-80a8-4996-ac4f-03df25cd3224/_apis/build/builds/49569/logs/35); The easiest way to test on Windows is to setup a local build sadly as we do not have GHA for this. I can kick off a one-off though if you have a PR. |
|
okay sounds good, i am ooo till monday but will look then. feel free to revert if more urgent then that |
|
I think its good to revert for the time being - we haven't had a good build of the development tools in a while now (and this would also block toolchain updates). Can someone accept the change so that it can be merged? |
Reverts #203
This seems to have broken the Windows build:
https://compnerd.visualstudio.com/3133d6ab-80a8-4996-ac4f-03df25cd3224/_apis/build/builds/49569/logs/35