[Serialized diagnostics] Ignore unknown records. #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To improve forward compatibility, ignore any unknown records encountered during deserialization rather than throwing an error. libclang has behaved this way forever, and we should do the same.
DougGregor
requested review from
abertelrud,
aciidgh,
friedbunny,
neonichu and
tomerd
as code owners
Member
Author
|
@swift-ci please smoke test |
Member
Author
|
@swift-ci please test |
tomerd
approved these changes
Jan 6, 2023
abertelrud
approved these changes
Jan 6, 2023
compnerd
reviewed
Jan 6, 2023
Member
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
@DougGregor where is this used? IIRC swift-driver has a copy of the Bitcode deserialization logic.
Member
Author
SwiftPM has a little-used client of this ( |
DougGregor
added a commit
that referenced
this pull request
Jan 6, 2023
To improve forward compatibility, ignore any unknown records encountered during deserialization rather than throwing an error. libclang has behaved this way forever, and we should do the same. (cherry picked from commit 1ed3a9b)
DougGregor
added a commit
that referenced
this pull request
Jan 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve forward compatibility, ignore any unknown records encountered during deserialization rather than throwing an error. libclang has behaved this way forever, and we should do the same.