Skip to content

[Serialized diagnostics] Ignore unknown records. #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DougGregor merged 1 commit into from
Jan 6, 2023
Merged

[Serialized diagnostics] Ignore unknown records. #379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Sources/TSCUtility/SerializedDiagnostics.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,8 @@ extension SerializedDiagnostics {
}

case .version, nil:
throw Error.unexpectedRecord
// Ignore unknown records, for future compatibility
continue
}
}

Expand Down
Binary file added Tests/TSCUtilityTests/Inputs/string_init_ambig.dia
View file
Open in desktop
Binary file not shown.
10 changes: 10 additions & 0 deletions Tests/TSCUtilityTests/SerializedDiagnosticsTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,16 @@ final class SerializedDiagnosticsTests: XCTestCase {
XCTAssertEqual(diag.fixIts.count, 0)
}

func testReadDiagsWithUnknownRecord() throws {
let serializedDiagnosticsPath = AbsolutePath(path: #file).parentDirectory
.appending(components: "Inputs", "string_init_ambig.dia")
let contents = try localFileSystem.readFileContents(serializedDiagnosticsPath)
let serializedDiags = try SerializedDiagnostics(bytes: contents)

XCTAssertEqual(serializedDiags.versionNumber, 2)
XCTAssertEqual(serializedDiags.diagnostics.count, 35)
}

func testReadClangSerializedDiags() throws {
let serializedDiagnosticsPath = AbsolutePath(path: #file).parentDirectory
.appending(components: "Inputs", "clang.dia")
Expand Down