Merge 2020-07-28 into tensorflow #33160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Constraint system] Limit edge contraction to BindParam.
…in Explicit Module Build mode. In order to avoid accidentally implicitly loading modules that are expected but were not provided as explicit inputs. - Use either SerializedModuleLoader or ExplicitSwiftModuleLoader for loading of partial modules, depending on whether we are in Explicit Module Build or Implicit Module Build mode.
[CodeCompletion] Don't throw away parsed return type for function decls
gyb: special case list for conversion
…32998) This PR adds a SWIFT_APPEND_VC_REV Cmake option (in symmetry with LLVM's LLVM_APPEND_VC_REV). When enabled, lib/Basic/SwiftRevision.inc header contains git commit hash and repository information, e.g. #define SWIFT_REVISION "ed4cef9b839d4a87618758d8b8705ab66b61917f" #define SWIFT_REPOSITORY "https://github.com/scentini/swift.git" This is useful for keeping track of the VCS state that produced a binary. But for local development builds, this information is often ignored and since this file is invalidated by every git commit or git checkout command and it leads to long rebuilds, it's useful to have a switch to disable this behavior. When SWIFT_APPEND_VC_REV is disabled, lib/Basic/SwiftRevision.inc contains: #undef SWIFT_REVISION #undef SWIFT_REPOSITORY
rdar://problem/65935026
After the TypeLocs were removed here, the TypeRepr from the IsExpr was the only thing providing access to syntactic information from the parent IsExpr. In order to support this, it was possible to construct a bizarre ConditionalCheckedCastExpr that contained both semantic and syntactic information. This doesn't comport with the rest of the casting nodes, which force you to pick one or the other. Since we're rewriting an IsExpr into a EnumIsCaseExpr, let's just stash the syntactic information there. This unblocks a bit of cleanup.
…ReplaceEnd This started failing in one CI job that has asan, but it's unclear whether there is a sanitizer issue or if it's a timing issue, etc. Disabling while we investigate the root cause. rdar://65934938
…tationsRangeShiftingAfterEditReplaceEnd [asan] Temporarily disable EditTest.AnnotationsRangeShiftingAfterEdit…
[Explicit Module Builds] Prevent SerializedModuleLoader from running in Explicit Module Build mode.
[Property Wrappers] Fix property wrapper initialization type checking when `wrappedValue` is an optional of a generic parameter.
Introduce a new frontend flag -enable-volatile-modules to trigger loading swiftmodule files as volatile and avoid using mmap. Revert the default behavior to using mmap.
Three issues addressed here: 1. Dependency on dictionary iteration order CharacterProperties.swift.gyb iterated a dictionary to produce its output. Changed this to a list of tuples to ensure the order is predictable. 2. Python3 `map` returns an iterator, not a list Changed a bunch of `map` calls to `list(map(...))` to ensure the result is a list 3. Python3 `int()` expects a string, won't accept a list of characters Added a concatenation step that is effectively a no-op on Python2
… valid alternative module names are equal Framework authors may move a type along with its extensions from a high-level framework to a low-level one. We should compare alternative module names for them to check if they should be considered from the same module to preserve ABI stability. rdar://65889766
[stdlib] Only include _getMetadataSection functions in stdlib builds w/ assertions
…t-destructor-name [cxx-interop] [nfc] HasMemberWithDestructor => StructWithSubobjectDestructor in comment.
SIL optimizer: Add a new string optimization
…licts with lazy variable storage property (#33152)
Remove the ability to build this dependency.
IRGen: always execute the coroutine lowering pass
Temporary patch to fix SwiftReflectionTest build after 014918c: ``` swift/stdlib/private/SwiftReflectionTest/SwiftReflectionTest.swift:141:10: error: cannot find '_getMetadataSection' in scope return _getMetadataSection(UInt(i)).map { rawPointer in ^~~~~~~~~~~~~~~~~~~ swift/stdlib/private/SwiftReflectionTest/SwiftReflectionTest.swift:155:17: error: cannot find '_getMetadataSectionCount' in scope return UInt32(_getMetadataSectionCount()) ^~~~~~~~~~~~~~~~~~~~~~~~ ``` Robust fix coming later.
The test passes on tensorflow branch without issue.
build: remove tensorflow-swift-apis from the master branch
[AST] Mark repr invalid only if `@autoclosure` parameter doesn't poin…
Revert 2bf0ee4 from master branch. tensorflow branch needs to keep tensorflow/swift-apis as a dependency.
Update llvm-project.
* [Python3] Fix "undefined symbol 'unicode'" from python_lint This is a little tricky. Python 2 "unicode" was renamed to "str" in Python 3. For Python 2 compatibility, we need to use "unicode" in a couple of places, but that's not defined on Python 3, which causes python_lint errors (even if the reference is never actually executed). To workaround this, when running in Python 3, define "unicode" as a synonym for "str". This defines the symbol (avoiding the "undefined symbol" error from python lint) while preserving the correct functionality on both Python 2 and Python 3. When we drop Python 2 support (which we should do as soon as possible), we can drop this workaround and globally replace "unicode" with "str" to get the right Python 3-only functionality.
Use correct relative import for Python 2&3 Remove unused variable Fix import ordering per python_lint
PythonKit was removed as a Swift build dependency in 9f0e0a6. PythonKit was instead added as a CMake dependency of tensorflow/swift-apis in tensorflow/swift-apis#1045.
|
swiftlang/llvm-project#1559 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.