[DiagnosticVerifier] Add -verify-ignore-macro-note #84870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The _SwiftifyImport macro is emitted into an unnamed buffer and then parsed, pretending it was in the header all along. This makes it hard to add `expected-note` comments for `diag::in_macro_expansion` when they point here. That's okay, because the macro expansion has already been pointed out by `expected-expansion` directives. But -verify-ignore-unrelated is too blunt of a tool, so this adds -verify-ignore-macro-note to ignore these specific diagnostics.
hnrklssn
requested review from
DougGregor,
artemcm and
tshortli
as code owners
Member
Author
|
@swift-ci please smoke test |
Xazax-hun
approved these changes
Oct 14, 2025
Member
Author
|
@swift-ci please smoke test macos platform |
Member
Author
|
@swift-ci please smoke test macos platform |
This was referenced Oct 15, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The _SwiftifyImport macro is emitted into an unnamed buffer and then parsed, pretending it was in the header all along. This makes it hard to add
expected-notecomments fordiag::in_macro_expansionwhen they point here. That's okay, because the macro expansion has already been pointed out byexpected-expansiondirectives. But -verify-ignore-unrelated is too blunt of a tool, so this adds -verify-ignore-macro-note to ignore these specific diagnostics.Extracted from 3e25af2