[MacrosOnImports] Don't inherit imports with unfulfilled required clauses
#84896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hnrklssn
requested review from
DougGregor,
Xazax-hun,
artemcm,
beccadax,
egorzhdan,
fahadnayyar,
ian-twilightcoder,
j-hui,
susmonteiro,
tshortli and
zoecarver
as code owners
Member
Author
|
@swift-ci please smoke test |
Closed
Xazax-hun
approved these changes
Oct 15, 2025
Inheriting a clang import marked `requires: !swift` will always result in an error. This skips such imports, which *may* result in name lookup errors instead, but also may not, depending on the module. rdar://161795145
Imports of modules marked `requires: cplusplus` should only be inherited when C++ interop is enabled. Similarly, imports of modules marked `requires: !cplusplus` should only be inherited when C++ interop is disabled.
hnrklssn
force-pushed
the
inherit-skip-unfulfilled-require
branch
from
f4ba962 to
8542903
Compare
Member
Author
|
Fixed test case on Windows. Rebased on top of main after merging #84870 |
Member
Author
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inheriting a clang import marked
requires: !swiftwill always resultin an error. This skips such imports, which may result in name lookup
errors instead, but also may not, depending on the module.
Similarly, imports of modules marked
requires: cplusplusshould only be inheritedwhen C++ interop is enabled, and imports of modules marked
requires: !cplusplusshould only be inherited when C++ interop isdisabled.
rdar://161795145
Based on top of #84870
Extracted from #84642