[SIL] Add asmname attribute to SIL functions and global variables #84939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougGregor
requested review from
AnthonyLatsis,
eeckstein,
jckarter,
kavon,
rjmccall and
xymus
as code owners
Member
Author
|
@swift-ci please smoke test |
DougGregor
force-pushed
the
sil-asmname-and-section
branch
from
630da51 to
03ec963
Compare
Member
Author
|
@swift-ci please smoke test |
The asmname attribute allows one to specify the name that will be used when lowering a given SIL declaration to LLVM IR. It is not currently exposed in the surface language. Make sure this attribute round-trips through the parser and serialization. Part of rdar://137014448O.
Fixes rdar://162549960.
DougGregor
force-pushed
the
sil-asmname-and-section
branch
from
03ec963 to
081b5cd
Compare
Member
Author
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
asmnameattribute to SIL functions and global variables, which provides a different name that will be used when lowering the symbol to LLVM IR. Make sure asmname lowers correctly and round-trips through serialized SIL. This is part of a larger scheme to prevent Swift-level type differences in the declarations of C functions from manifesting as deserialization failures for SIL (rdar://137014448). The substantive part of that is still to come.While here, use the SIL serialization logic needed for
asmnameto make the existingsectionattribute on SIL functions properly round-trip through SIL serialization. Do the same for SIL global variables, which also means adding support for parsing thesectionattribute on SIL global variables. Fixes rdar://162549960.