[SILGen] Map the @_extern(c) C function name over to the asmname of a SIL function #84948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The asmname attribute allows one to specify the name that will be used when lowering a given SIL declaration to LLVM IR. It is not currently exposed in the surface language. Make sure this attribute round-trips through the parser and serialization. Part of rdar://137014448O.
Fixes rdar://162549960.
… a SIL function `@_extern(c)` is meant for referencing C functions defined outside of this Swift file. Instead of using the C function name as the SIL function name, which is prone to collisions across different Swift modules, place make the C function name the "asmname" of the corresponding SIL function. Show that this prevents deserialization errors when there are conflicting Swift-level types for the same `@_extern(c)`-named symbol across modules. Part of rdar://137014448. Instead of using the C name as the mangled name of a SIL function
DougGregor
requested review from
AnthonyLatsis,
eeckstein,
jckarter,
kavon,
ktoso,
rjmccall and
xymus
as code owners
Member
Author
|
Only the last commit is new; this is sitting on top of #84939. |
Member
Author
|
@swift-ci please smoke test |
Also fix up a test
Member
Author
|
@swift-ci please smoke test |
Member
Author
|
@swift-ci please smoke test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@_extern(c)is meant for referencing C functions defined outside of this Swift file. Instead of using the C function name as the SIL function name, which is prone to collisions across different Swift modules, place make the C function name the "asmname" of the corresponding SIL function. Show that this prevents deserialization errors when there are conflicting Swift-level types for the same@_extern(c)-named symbol across modules.Part of rdar://137014448.