Sema: Allow more references to restricted decls from embedded code #85182
+222
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Access-level on imports don't hide the dependency in non-library-evolution mode. We can allow implicitly always-emit-into-client function bodies from embedded mode to references the dependencies. rdar://163519185
Embedded mode use only binary swiftmodules for distribution, SPI will always be visible. We can allow implicitly always-emit-into-client function bodies from the embedded mode to references SPIs. rdar://163519075
Contributor
Author
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check on functions that are implicitly always-emit-into-client from the embedded mode was too strict. Loosen some restriction so functions don't need to be marked
@_neverEmitIntoClientto reference SPI or decls from an internally imported module.Follow up to #84630.
rdar://163519075
rdar://163519185